Subject: Re: [bug#48551] [PATCH] gnu: Add font-victor-mono
From: Roel Janssen <[email-masked]>
To: aecepoglu <[email-masked]>, [email-masked]
Cc: [email-masked]
Date: Fri, 21 May 2021 13:35:34 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On Fri, 2021-05-21 at 02:10 +0300, aecepoglu wrote:
> * gnu/packages/fonts.scm (font-victor-mono): New variable.
> ---
>  gnu/packages/fonts.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/gnu/packages/fonts.scm b/gnu/packages/fonts.scm
> index 039a9e5b4a..8461729230 100644
> --- a/gnu/packages/fonts.scm
> +++ b/gnu/packages/fonts.scm
> @@ -1971,6 +1971,26 @@ always uses Farsi digits, and does not include
> Latin glyphs from Roboto.
>              "file://LICENSE" "Bitstream Vera License")
>             license:asl2.0))))           ; Latin glyphs from Roboto
>  
> +(define-public font-victor-mono
> +  (package
> +   (name "font-victor-mono")
> +   (version "1.4.2")
> +   (source (origin
> +            (method url-fetch/zipbomb)
> +            (uri (string-append
> +                       "https://github.com/rubjo/victor-mono/raw/v"
> +                       version
> +                       "/public/VictorMonoAll.zip"))
> +            (sha256
> "01260vja0d22mcvkzspf0xnl7b851r0265arqkm12q1vagzyxvkm")))
> +   (build-system font-build-system)
> +   (synopsis "Font with support for italics and ligatures")
> +   (description "Victor Mono is an open-source monospaced font with
> +optional semi-connected cursive italics and programming symbol
> ligatures.
> +This package provides only TrueType files (TTF).
> +It comes in seven weights and Roman, Italic and Oblique styles.")
> +   (home-page "https://rubjo.github.io/victor-mono")

I added a / to the end of the URI as indicated by "guix lint".

> +   (license license:expat)))
> +
>  (define-public font-meera-inimai
>    (package
>      (name "font-meera-inimai")

Otherwise, LGTM!  I pushed this patch (with the slight modification) in
652a03888e1609bd1a687326760436867fe2abb7.

Thank you!

Kind regards,
Roel Janssen