Subject: Re: [bug#47356] [PATCH 2/2] gnu: Add emacs-julia-snail.
From: Christopher Baines <[email-masked]>
To: zimoun <[email-masked]>
Cc: [email-masked]
Date: Wed, 31 Mar 2021 08:19:31 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

zimoun <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-julia-snail): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 40 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 2d26cae5ca..71b88cca07 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -8720,6 +8720,46 @@ the help system and the debugger.  It is recommended that you use this minor
>  mode with the package emacs-julia-mode.")
>      (license license:expat)))
>  
> +(define-public emacs-julia-snail
> +  (package
> +    (name "emacs-julia-snail")
> +    (version "1.0.0rc4")               ;rc5 requires CSTParser (julia package)
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/gcv/julia-snail")
> +                    (commit version)))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "065ix3jycsx3wvkq7a6060i93caxisdvgxgqb1l6rq15n4qln78y"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'JuliaSnail-jl
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out(assoc-ref outputs "out")))

I added a space here after out.

> +               (install-file "JuliaSnail.jl"
> +                             (string-append out "/share/emacs/site-lisp/")))
> +             #t)))))
> +    (inputs
> +     `(("emacs-dash" ,emacs-dash)
> +       ("emacs-s" ,emacs-s)
> +       ("emacs-spinner" ,emacs-spinner)
> +       ("emacs-xref" ,emacs-xref)))
> +    (propagated-inputs
> +     `(("libvterm" ,libvterm)
> +       ("emacs-julia-mode" ,emacs-julia-mode) ;required by parser
> +       ("emacs-parsec" ,emacs-parsec)         ;required by parser
> +       ("emacs-vterm" ,emacs-vterm)))
> +    (home-page "https://github.com/gcv/julia-snail")
> +    (synopsis "Development environment and REPL interaction package for Julia")
> +    (description "This package provides a development environment and REPL
> +interaction package for Julia in the spirit of Common Lisp’s SLIME and
> +Clojure’s CIDER.  It enables convenient and dynamic REPL-driven development.")
> +    (license license:gpl3)))
> +
>  (define-public emacs-smex
>    (package
>      (name "emacs-smex")

Both patches look good to me, and they build at least. They're on master
as of f27bdad0a7a3c3d6edbfa2c6809f19592fe5ba56.

Thanks,

Chris