Subject: Re: bug#45867: hurd-vm: custom disk-size ignored
From: Jan Nieuwenhuizen <[email-masked]>
To: [email-masked]
Date: Thu, 14 Jan 2021 20:21:32 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Jan Nieuwenhuizen writes:

> On current master, setting a bigger disk-size for a childhurd
>
>       (service hurd-vm-service-type
>                (hurd-vm-configuration
>                 (disk-size (* 12 (expt 2 30))) ;12GiB
>
>
> is being ignored.  I am suspecting

[..]

> disk-size goes unused.  So we probably need something like
>
> diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm
> index f435630faf..3ede822183 100644
> --- a/gnu/services/virtualization.scm
> +++ b/gnu/services/virtualization.scm
> @@ -917,7 +917,9 @@ is added to the OS specified in CONFIG."
>           (disk-size (hurd-vm-configuration-disk-size config))
>           (type      (lookup-image-type-by-name 'hurd-qcow2))
>           (os->image (image-type-constructor type)))
> -    (system-image (os->image os))))
> +    (system-image
> +     (image (inherit (os->image os))
> +            (size disk-size)))))
>  
>  (define (hurd-vm-port config base)
>    "Return the forwarded vm port for this childhurd config."

I can connfirm this works, pushed to master as 5b785b2a62b885a65aeece1399f7e3a732dd1cea.

> Greetings,
> Janneke

-- 
Jan Nieuwenhuizen <[email-masked]> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.com