Subject: Re: [bug#43946] [PATCH] doc: Add item to "Submitting Patches" section.
From: Oleg Pykhalov <[email-masked]>
To: zimoun <[email-masked]>
Cc: [email-masked]
Date: Sat, 24 Oct 2020 12:01:51 +0300
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

zimoun <[email-masked]> writes:

> * doc/contributing.texi (Submitting Patches): Add item about 'git-format-patch
> --base'.
> ---
>  doc/contributing.texi | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/contributing.texi b/doc/contributing.texi
> index af3601442e..5ea3cb1899 100644
> --- a/doc/contributing.texi
> +++ b/doc/contributing.texi
> @@ -932,6 +932,12 @@ Before submitting a patch that adds or modifies a package definition,
>  please run through this check list:
>  
>  @enumerate
> +@cindex @code{git format-patch}
> +@cindex @code{git-format-patch}
> +@item
> +We recommend to use the command @code{git format-patch --base} to
> +include the commit where your patch applies.

“git format-patch” already mentioned in the documentation in the first
paragraph https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html

Do I miss something?  Fill free to reopen the issue ;-)

Oleg.