Subject: Re: bug#39551: Cannot declare an NFS mount using the <file-system> record
From: Maxim Cournoyer <[email-masked]>
To: Giovanni Biscuolo <[email-masked]>
Cc: [email-masked]
Date: Tue, 18 Feb 2020 12:28:33 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Giovanni Biscuolo <[email-masked]> writes:

> Hello,
>
> Maxim Cournoyer <[email-masked]> writes:
>
>> The attached patch fixes this issue
>
> [...]
>
>> diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
>> index b0386a1392..26a1599a93 100644
>> --- a/guix/scripts/system.scm
>> +++ b/guix/scripts/system.scm
>> @@ -566,6 +566,8 @@ any, are available.  Raise an error if they're not."
>>                (and (file-system-mount? fs)
>>                     (not (member (file-system-type fs)
>>                                  %pseudo-file-system-types))
>> +                   ;; Fixes issue #39551 (see: https://bugs.gnu.org/39551).
>> +                   (not (string-prefix? "nfs" (file-system-type fs)))
>>                     (not (memq 'bind-mount (file-system-flags fs)))))
>>              file-systems))
>
> Please is it possible to also add nfs4 to this fix?
>
> Thanks! Gio'

Done with commit adbdf188c28c503a9c875b793bc88548d3cd702f.  Please not
that booting with NFS still seems to be problematic, at least in my
experience.  I had to use set mount? to #f and check? to #f as well in
the <file-system> record.  I'll try to address these issues separately.

Maxim