Subject: Re: [bug#38995] [PATCH] gnu: Add python-git-multimail.
From: Christopher Baines <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked]
Date: Thu, 16 Jan 2020 21:32:02 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> writes:

> Hi Chris!
>
> Christopher Baines <[email-masked]> skribis:
>
>> * gnu/packages/version-control.scm (python-git-multimail): New variable.
>
> [...]
>
>> +             (substitute* "git-multimail/git_multimail.py"
>> +               (("GIT_EXECUTABLE = 'git'")
>> +                (string-append "GIT_EXECUTABLE = '"
>> +                               (assoc-ref inputs "git") "/bin/git"
>> +                               "'"))
>> +               (("/usr/sbin/sendmail")
>> +                (string-append (assoc-ref inputs "sendmail")
>> +                               "/usr/sbin/sendmail',
>> +        '/usr/sbin/sendmail")))
>
> The second clause is intriguing, but as long as it has the intended
> effect, LGTM!  :-)

I was thinking something about preserving the existing behaviour when I
kept /usr/sbin/sendmail in the list, but that doesn't make sense, as the
list is searched in order, and sendmail from the Guix package will
always be present.

I've removed the odd bit, and pushed this as
add8d50911f55464a1ecd003521997d6c7d912f3 now.

Thanks for taking a look!

Chris