Subject: Re: [bug#37968] [PATCH] gnu: python-pyro4: Update to 4.77.
From: Marius Bakke <[email-masked]>
To: Giacomo Leidi <[email-masked]>, [email-masked]
Cc: Giacomo Leidi <[email-masked]>
Date: Mon, 28 Oct 2019 22:54:58 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Giacomo Leidi <[email-masked]> writes:

> * gnu/packages/python-xyz.scm (python-pyro4): Update to 4.77.

Applied with this tiny change:

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 57fb77a95a..bf5371c07a 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -14337,9 +14337,8 @@ such as figshare or Zenodo.")
        (sha256
         (base32 "0gsjg869y4gpy265s1gj1f2qy6jn5iz8r2bwwnq78r1r5yi15zib"))))
     (build-system python-build-system)
-    ;; FIXME
     (arguments
-     '(#:tests? #f)) ; The test suite requires network access.
+     '(#:tests? #f)) ;FIXME: Some tests require network access.
     (native-inputs
      `(("python-cloudpickle" ,python-cloudpickle)
        ("python-dill" ,python-dill)

Apparently the tests never ran before.  In the future, it would be great
to selectively disable just the tests that require network access, so
that we notice any breakage early.

Anyway, thanks for the patch!