Subject: Re: [bug#34698] [PATCH] gnu: add org-noter.
From: Brett Gilio <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: [email-masked],Nicolò Balzarotti <[email-masked]>
Date: Mon, 09 Dec 2019 22:55:51 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès <[email-masked]> writes:

> Hello,
>
> Nicolò Balzarotti <[email-masked]> skribis:
>
>> ---
>>  gnu/packages/emacs-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>
> Could you add a commit log that follows our conventions?
>
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://stable.melpa.org/packages/org-noter-"
>> +             version
>> +             ".el"))
>
> Since files on MELPA are unversioned and regularly modified in place,
> could you instead use the upstream URL (presumably the GitHub repo)?
>
>> +    (synopsis
>> +     "A synchronized, Org-mode, document annotator")
>          ^
> ‘guix lint’ probably complains about this; please remove the “A”.
>
>> +    (description
>> +     "The idea is to let you create notes that are kept in sync when you scroll through the
>> +document, but that are external to it - the notes themselves live in an Org-mode file. As
>> +such, this leverages the power of Org-mode (the notes may have outlines, latex fragments,
>> +babel, etc...) while acting like notes that are made /in/ the document.
>> +
>> +Also, I must thank Sebastian for the original idea and inspiration!
>> +Link to the original Interleave package:
>> +https://github.com/rudolfochrist/interleave
>
> Please change the description to describe the package contents from the
> viewpoint of an outsider.  See the guidelines at
> <https://www.gnu.org/software/guix/manual/en/html_node/Synopses-and-Descriptions.html>.
>
>> +    (license license:gpl3)))
>
> The source file header explicitly says “or any later version”, so it
> should be ‘license:gpl3+’.
>
> Could you send an updated patch?
>
> Thank you,
> Ludo’.
>
>
>
>

Hi Ludo' and Nicolò,

Closing this as it was added in commit
576cb396eac4e8cea2b54d96382f8e77f3584e89 on 2019-06-13.

Thanks!

-- 
Brett M. Gilio
Homepage -- https://scm.pw/
GNU Guix -- https://guix.gnu.org/