Subject: Re: [bug#34200] [PATCH] gnu: Add stoken.
From: Eric Bavier <[email-masked]>
To: Ricardo Wurmus <[email-masked]>, [email-masked]
Date: Sat, 26 Jan 2019 17:48:54 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

On Sat, 26 Jan 2019 14:53:49 +0100
Ricardo Wurmus <[email-masked]> wrote:

> Hi Eric,
> 
> thanks for the patch!
> 
> > * gnu/packages/crypto.scm (stoken): New variable.  
> […]
> > +    (home-page "https://stoken.sf.net")  
> 
> Sourceforge home pages don’t seem to support HTTPS.

Hm, transcription error, I guess.

> 
> > +    (synopsis "Software Token for cryptographic authentication")
> > +    (description
> > +     "@code{stoken} is a tokencode generator compatible with RSA SecurID
> > +128-bit (AES) tokens.  This package contains a standalong command-line program
> > +that allows for importing token seeds, generating tokencodes, and various
> > +utility/testing functions.")
> > +    (license license:lgpl2.1+)))  
> 
> “standalong” should be “standalone”; I’d also separate the term
> “tokencodes”.

Done.

> 
> Other than that it looks good to me!

Thanks for the review, Ricardo!

Pushed with fixes to master in c2ab3b84398df0b26e6127ea0c336a39e8950d17.

`~Eric