Subject: Re: [bug#32364] [PATCH] gnu: Add mozjs-52.
From: Ricardo Wurmus <[email-masked]>
To: Kei Kebreau <[email-masked]>
Cc: Efraim Flashner <[email-masked]>, [email-masked]
Date: Tue, 7 Aug 2018 13:53:49 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Kei Kebreau <[email-masked]> writes:

> Efraim Flashner <[email-masked]> writes:
>
>> On Fri, Aug 03, 2018 at 06:15:42PM +0200, Ricardo Wurmus wrote:
>>> + ;; No releases yet at
>>> <https://archive.mozilla.org/pub/spidermonkey/releases/>.
>>> + ;; While we could take a snapshot of the complete mozilla-esr52
>>> repository at
>>> + ;;
>>> <https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr52&filter-searchStr=sm-tc>,
>>> +  ;; we take the Debian version instead, because it is easier to work with.
>>> +  (let ((commit "6507e63cc416fd7a3269e390efe712f8b56f374a")
>>> +        (revision "1"))
>>> +    (package (inherit mozjs-38)
>>
>> Do the other ones have their name listed? I had to build 'mozjs@52'
>> instead of 'mozjs-52'
>>
>
> I mangaged to build this with just 'mozjs'.
>
>>> +      (version (git-version "52.0-0." revision commit))
>>> +      (source (origin
>>> +                (method git-fetch)
>>> +                (uri (git-reference
>>
>>
>> This built with no problems on aarch64 and the package looks good. It
>> also built with '--system=armhf-linux' on my aarch64 board.
>
> I built this successfully for x86_64-linux, i686-linux, and armhf-linux
> on a x86_64-linux computer.

Thank you both for testing the patch.

I pushed a slightly modified version of this patch to
wip-gnome-upgrades, which is supposed to be merged into core-updates
soon.

The patch that I sent here results in a package that cannot be used with
GJS (it segfaults).  I had to apply a patch that is included in the
Debian copy of the source code.

--
Ricardo