Subject: Re: [bug#31173] [PATCH] gnu: Add python-onetimepass.
From: Tomáš Čech <[email-masked]>
To: Marius Bakke <[email-masked]>
Cc: [email-masked]
Date: Sat, 21 Apr 2018 08:36:20 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On Tue, Apr 17, 2018 at 12:47:59AM +0200, Marius Bakke wrote:
>Tomáš Čech <[email-masked]> writes:
>
>> * gnu/packages/python.scm (python-onetimepass): New variable.
>
>[...]
>
>> +(define-public python-onetimepass
>> +  (package
>> +    (name "python-onetimepass")
>
>Please check the indentation of this package.  Use
>'./etc/indent-code.el' if you're not an emacs user.

as with other patches I sent - I run it through and result is
unchanged. But I'll be careful about that, thanks!

>> +    (version "1.0.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "onetimepass" version))
>> +       (sha256
>> +        (base32
>> +         "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5"))))
>> +    (build-system python-build-system)
>> +    (inputs
>> +       `(("python-six" ,python-six)))
>
>Should this not be a propagated input?

It didn't seem so.

>> +    (home-page "https://github.com/tadeck/onetimepass/")
>> +    (synopsis "Python one-time password library")
>
>Maybe s/Python// even.

Fixed.

>> +    (description "Pyhton one-time password library for HMAC-based (HOTP) and
>                      ^^^ typo (importo?)

Fixed.

>> +time-based (TOTP) passwords.")
>
>Please also turn this into a complete sentence.  "@code{onetimepass} is
>a Python library for...".  Bonus points if you can mention use-cases and
>in general expand on it :-)
>
>> +    (license license:x11)))
>
>I believe this is "expat".

Fixed.

>Otherwise LGTM.

Pushed.

Thank you for your review!

Best regards,

S_W