Subject: Re: [bug#27938] [PATCH] gnu: git: Enable tests.
From: Marius Bakke <[email-masked]>
To: Leo Famulari <[email-masked]>
Cc: [email-masked]
Date: Fri, 04 Aug 2017 01:35:34 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Leo Famulari <[email-masked]> writes:

> On Thu, Aug 03, 2017 at 11:07:30PM +0200, Marius Bakke wrote:
>> * gnu/packages/version-control.scm (git)[arguments]: Remove #:tests?. Add
>> 'patch-tests' phase.
>
> Wow, awesome! LGTM.

Thanks for the fast review! Pushed in c9f4f56b24801718d89c2520bec08867516e1371.

>
>> +            ;; Un-do shebang patching here to prevent checksum mismatch.
>> +            (substitute* '("t/t4034/perl/pre" "t/t4034/perl/post")
>> +              (("^#!.*/bin/perl") "#!/usr/bin/perl"))
>
> I've been thinking, we should have a way to pass a list of directories
> or files to exclude from the shebang patcher. We have a few packages
> that include files where patching the shebang is the wrong thing to do.
> For example, the Git example hook scripts.

That would be nice. I guess we can experiment with overriding the
various patching phases and see what works.