Subject: Re: bug#17770: Please disable inotify for Veritas FS (vxfs switch to remote)
From: Pádraig Brady <[email-masked]>
To: [email-masked]
Cc: [email-masked]
Date: Fri, 13 Jun 2014 09:31:00 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

On 06/13/2014 08:46 AM, Ondrej Vasik wrote:
> Hi,
> as reported in https://bugzilla.redhat.com/show_bug.cgi?id=1104244 ,
> Veritas Clustered Filesystem ( vxfs ) has issues with inotify support -
> thus tail --follow doesn't work properly. Can you please add this
> filesystem to the list of remote filesystem?

The attached should fix it up.

thanks,
Pádraig.

From f60aab9103499c48c055eb3678a4c5b0893312d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?P=C3=A1draig=20Brady?= <[email-masked]>
Date: Fri, 13 Jun 2014 09:16:31 +0100
Subject: [PATCH] tail: fix to use polling mode for VXFS
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Veritas File System can run in single instance or clustered mode,
so mark as remote to avoid using inotify for the latter case.

* src/stat.c (human_fstype): Tag VXFS as remote to use polling
for the VXCFS variant.
* NEWS: Mention the bug fix.

Reported by Ondřej Vašík in http://bugzilla.redhat.com/1104244
Fixes http://bugs.gnu.org/17770
---
 NEWS       |    3 +++
 src/stat.c |    4 +++-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/NEWS b/NEWS
index 2f43da6..5d1fe99 100644
--- a/NEWS
+++ b/NEWS
@@ -77,6 +77,9 @@ GNU coreutils NEWS                                    -*- outline -*-
   shuf --repeat no longer dumps core if the input is empty.
   [bug introduced with the --repeat feature in coreutils-8.22]
 
+  tail -f now uses polling mode for VXFS to cater for its clustered mode.
+  [bug introduced with inotify support added in coreutils-7.5]
+
 ** New features
 
   od accepts a new option: --endian=TYPE to handle inputs with different byte
diff --git a/src/stat.c b/src/stat.c
index 0f67d22..b65dbe5 100644
--- a/src/stat.c
+++ b/src/stat.c
@@ -443,7 +443,9 @@ human_fstype (STRUCT_STATVFS const *statfsbuf)
       return "v9fs";
     case S_MAGIC_VMHGFS: /* 0xBACBACBC remote */
       return "vmhgfs";
-    case S_MAGIC_VXFS: /* 0xA501FCF5 local */
+    case S_MAGIC_VXFS: /* 0xA501FCF5 remote */
+      /* Veritas File System can run in single instance or clustered mode,
+         so mark as remote to cater for the latter case.  */
       return "vxfs";
     case S_MAGIC_VZFS: /* 0x565A4653 local */
       return "vzfs";
-- 
1.7.7.6