Subject: [PATCH] gnu: Add aacircuit.
From: Sharlatan Hellseher <[email-masked]>
To: [email-masked]
Date: Sat, 22 Mar 2025 16:10:32 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Pushed to master as fa0bbeaf6763540a8b5e1bf2ad58b8b4f0d1af18.

I've applied minor modifications, remove the need of python-flake8 and
addd commens on commit an use of Nose test runner: 
--8<---------------cut here---------------start------------->8---
@@ -177,6 +177,7 @@ (define-module (gnu packages engineering)
   #:use-module ((srfi srfi-1) #:hide (zip)))
 
 (define-public aacircuit
+  ;; No release in PyPI or version tag on Git, use the latest commit.
   (let ((commit "18635c846754b6219da1a2ceb8977714f70004d0")
         (revision "0"))
     (package
@@ -199,6 +200,8 @@ (define-public aacircuit
             (replace 'check
               (lambda* (#:key tests? #:allow-other-keys)
                 (when tests?
+                  ;; Delete develompent test file.
+                  (delete-file "tests/test_flake.py")
                   ;; Exclude tests intended for visual review.
                   (setenv "NOSE_EXCLUDE"
                           (string-join '("test_export_pdf"
@@ -206,24 +209,25 @@ (define-public aacircuit
                                        ","))
                   (setenv "HOME" "/tmp")
                   (invoke "xvfb-run" "./testrunner.sh")))))))
-      (native-inputs (list python-flake8
-                           python-nose
-                           python-setuptools
-                           python-wheel
-                           xvfb-run))
-      (propagated-inputs (list gtk+
-                               python-bresenham
-                               python-platformdirs
-                               python-pycairo
-                               python-pyclip
-                               python-pygobject
-                               python-pypubsub))
+      (native-inputs
+       ;; XXX: Test runner may be migrated to Pytest
+       ;; <https://docs.pytest.org/en/7.1.x/how-to/nose.html> after report to
+       ;; the upstream to modify them, use deprecated Nose test runner for
+       ;; now.
+       (list python-nose
+             python-setuptools
+             python-wheel
+             xvfb-run))
+      (propagated-inputs
+       (list gtkp+
+             python-bresenham
+             python-platformdirs
+             python-pycairo
+             python-pyclip
+             python-pygobject
+             python-pypubsub))
       (home-page "https://github.com/Blokkendoos/AACircuit")
       (synopsis "Draw electronic circuits with ASCII characters")
       (description
-       "This is a pythonized, kind of reverse engineered version of original AACircuit
-written by Andreas Weber in Borland Delphi.  The idea and GUI layout are also
-taken from the original.")
+       "This is a pythonized, kind of reverse engineered version of original
+AACircuit written by Andreas Weber in Borland Delphi.  The idea and GUI layout
+are also taken from the original.")
       (license license:gpl3+)))))
--8<---------------cut here---------------end--------------->8---

--
Oleg