Subject: Re: bug#75712: HAVE_RSVG: svg_css_length_to_pixels doesn't handle RSVG_UNIT_CH
From: Pip Cet <[email-masked]>
To: Stefan Kangas <[email-masked]>
Cc: Eli Zaretskii <[email-masked]>, [email-masked]
Date: Tue, 21 Jan 2025 19:12:40 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

"Stefan Kangas" <[email-masked]> writes:

> Eli Zaretskii <[email-masked]> writes:
>
>>> Date: Tue, 21 Jan 2025 15:04:33 +0000
>>> From: Pip Cet <[email-masked]>
>>> Cc: Stefan Kangas <[email-masked]>, [email-masked]
>>>
>>> Here's a proposed patch which:
>>> 1. prints a warning about this situation (in case the library changes)
>>> 2. omits the default label so GCC also warns, even without -Wswitch-enum
>>> (in case the headers change)
>>> 3. includes too much commentary rather than too little.
>>
>> LGTM, thanks.  But please wait for Stefan to comment.
>
> LGTM, please install.

Pushed, closing.  Minor change compared to the patch I posted:

PSA: image_error takes Lisp_Object arguments, not integers.  Something
for your (ever-growing, no doubt) TODO list, maybe?

Pip