Subject: Re: [bug#75284] [PATCH v2] gnu: Add netcdf-cxx4 and netcdf-cxx4-parallel-openmpi.
From: Ludovic Courtès <[email-masked]>
To: Lars Bilke <[email-masked]>
Cc: Andreas Enge <[email-masked]>, [email-masked], Sharlatan Hellseher <[email-masked]>, Eric Bavier <[email-masked]>
Date: Mon, 20 Jan 2025 00:11:46 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Lars Bilke <[email-masked]> skribis:

> * gnu/packages/maths.scm (netcdf-cxx4): New variable.
> * gnu/packages/maths.scm (netcdf-cxx4-parallel-openmpi: New variable.
>
> Change-Id: I9781aa31567b80e20c528abb5e9289bc625bb3eb

Applied with the changes below: addressing a ‘guix lint’ issue, and
following the conventions at
<https://guix.gnu.org/manual/devel/en/html_node/Synopses-and-Descriptions.html>.

Thanks,
Ludo’.

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 5f40f751d3..4e3ea6df26 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -2391,6 +2391,7 @@ (define-public netcdf-cxx4
        (uri (git-reference
              (url "https://github.com/Unidata/netcdf-cxx4")
              (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
        (sha256
         (base32 "05kydd5z9iil5iv4fp7l11cicda5n5lsg5sdmsmc55xpspnsg7hr"))))
     (build-system cmake-build-system)
@@ -2424,18 +2425,22 @@ (define-public netcdf-cxx4
                           (("cxx=([[:graph:]]+)/bin/c\\+\\+")
                            "cxx=\"c++"))))))
        #:configure-flags (list (string-append "-DHDF5_C_LIBRARY_hdf5="
-                                              (assoc-ref %build-inputs "hdf5")
-                                              "/lib/libhdf5.so"))))
+                                              (search-input-file
+                                               %build-inputs
+                                               "/lib/libhdf5.so")))))
     (inputs (list netcdf hdf5))
     (home-page "https://github.com/Unidata/netcdf-cxx4")
     (synopsis "NetCDF C++ interface")
-    (description "C++ interface for NetCDF.")
+    (description
+     "This package provides a C++ interface to the NetCDF library for
+scientific data storage.")
     (license license:bsd-3)))
 
 (define-public netcdf-cxx4-parallel-openmpi
   (package
     (inherit netcdf-cxx4)
     (name "netcdf-cxx4-parallel-openmpi")
+    (synopsis "NetCDF C++ interface (with MPI support)")
     (inputs (modify-inputs (package-inputs netcdf-cxx4)
               (prepend openmpi)
               (replace "hdf5" hdf5-parallel-openmpi)