Subject: Re: [bug#71899] [PATCH v2] gnu: erlang-lfe: Make LFE compiler deterministic.
From: Andrew Tropin <[email-masked]>
To: Igor Goryachev via Guix-patches via <[email-masked]>, [email-masked]
Cc: Igor Goryachev <[email-masked]>
Date: Wed, 03 Jul 2024 07:30:57 +0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On 2024-07-02 15:46, Igor Goryachev via Guix-patches via wrote:

> * gnu/packages/erlang.scm (erlang-lfe): Make LFE compiler deterministic.
>
> Change-Id: I0cf00eeda8502384b746795802f1b2291d0e8a3b
> ---
>  gnu/packages/erlang.scm | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/gnu/packages/erlang.scm b/gnu/packages/erlang.scm
> index dd07c1a617..a236722474 100644
> --- a/gnu/packages/erlang.scm
> +++ b/gnu/packages/erlang.scm
> @@ -792,6 +792,13 @@ (define-public erlang-lfe
>        #:phases
>        #~(modify-phases %standard-phases
>            (delete 'configure)
> +          ;; By default LFE compiler itself is not deterministic. We fix it
> +          ;; here. For more details see: https://github.com/lfe/lfe/issues/492.
> +          (add-after 'unpack 'make-deterministic
> +           (lambda _
> +             (substitute* "src/lfe_env.erl"
> +                 (("maps:fold\\(F, A, D\\)")
> +                  "lists:sort(maps:fold(F, A, D))"))))
>            ;; The following is inspired by rebar-build-system.scm
>            (add-before 'check 'erlang-depends
>              (lambda* (#:key inputs #:allow-other-keys)
>
> base-commit: 4b3a553ca5ba5ac190739309eb5f7aa8170cf2a8

Thank you for making guix even more reproducible :)

Applied, pushed as
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=972c06dc79

-- 
Best regards,
Andrew Tropin