Subject: Re: bug#71374: [PATCH] Simplify 'help-enable-variable-value-editing' using
From: Philip Kaludercic <[email-masked]>
To: Jeremy Bryant <[email-masked]>
Cc: Eli Zaretskii <[email-masked]>, Stefan Kangas <[email-masked]>, [email-masked]
Date: Sun, 28 Jul 2024 12:04:28 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Jeremy Bryant <[email-masked]> writes:

> Stefan Kangas <[email-masked]> writes:
>
>> Philip Kaludercic <[email-masked]> writes:
>>
>>> Eli Zaretskii <[email-masked]> writes:
>>>
>>>>> From: Philip Kaludercic <[email-masked]>
>>>>> Date: Wed, 05 Jun 2024 06:55:46 +0000
>>>>>
>>>>> The main issue with this patch is that it drops the syntax highlighting
>>>>> in the *string edit* buffer, but we could fix that in a second patch by
>>>>> adding support to specify a major mode to inherit from when editing a
>>>>> string.
>>>>
>>>> Thanks.  This is basically a cleanup, yes?  IOW, there's nothing wrong
>>>> with the current implementation, right?  If so, I'd prefer to wait
>>>> with this until after the emacs-30 branch is cut.
>>>
>>> Right, it just seemed like the kind of thing where it would be natural
>>> to demonstrate string-edit.
>>
>> Feel free to install on master now, thanks.
>
> Philip, has this been installed on master?  Can the bug be closed?

I hadn't pushed the change, have done so now.  Closing the report.
Thanks for the reminder.

-- 
	Philip Kaludercic on peregrine