Subject: Re: bug#63566: [PATCH] gnu: add tcptrack
From: Maxim Cournoyer <[email-masked]>
To: Jakob Kirsch <[email-masked]>
Cc: Jelle Licht <[email-masked]>, [email-masked]
Date: Fri, 01 Sep 2023 10:38:50 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Jakob Kirsch <[email-masked]> writes:

> * gnu/packages/admin.scm (tcptrack): New variable
> ---
>  gnu/packages/admin.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 529a477ed0..3dd8b25836 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -4256,6 +4256,29 @@ (define-public thermald
>      (supported-systems '("i686-linux" "x86_64-linux"))
>      (license license:gpl2)))
>
> +(define-public tcptrack
> +  (package
> +    (name "tcptrack")
> +    (version "1.4.3")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/bchretien/tcptrack")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
> +    (build-system gnu-build-system)
> +    (inputs (list libpcap ncurses))
> +    (synopsis "Display information about TCP connections")
> +    (description
> +     "Tcptrack is a sniffer which displays information about TCP connections
> +it sees on a network interface.  This is a fork of Steve Benson’s tcptrack.")
> +    (home-page "https://github.com/bchretien/tcptrack")
> +    ; the COPYING file states the following license but the tcptrack.spec states just 'GPL'
> +    (license license:lgpl2.1)))

I've made the following small changes:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/admin.scm
@@ -4291,13 +4291,12 @@ (define-public tcptrack
                 "08lh3l67wn4kq9q0nfspc7rj0jvp9dzwjgxpvqliwcif8cy5mi45"))))
     (build-system gnu-build-system)
     (inputs (list libpcap ncurses))
-    (synopsis "Display information about TCP connections")
+    (synopsis "TCP connections sniffer")
     (description
      "Tcptrack is a sniffer which displays information about TCP connections
 it sees on a network interface.  This is a fork of Steve Benson’s tcptrack.")
     (home-page "https://github.com/bchretien/tcptrack")
-    ; the COPYING file states the following license but the tcptrack.spec states just 'GPL'
-    (license license:lgpl2.1)))
+    (license license:lgpl2.1+)))
 
 (define-public masscan
   (package
--8<---------------cut here---------------end--------------->8---

Fixing the license (note the + which means 'or later').  Conventionally
the synopsis is worded to describe what it *is* rather than what it
does (the later is kept for the description).

I've now installed the change, thank you!

-- 
Thanks,
Maxim