Subject: Re: bug#62282: [PATCH] gnu: gerbil: Upgrade to 0.17.0.
From: Ludovic Courtès <[email-masked]>
To: "J. Sims" <[email-masked]>
Cc: "[email-masked]" <[email-masked]>
Date: Sun, 09 Apr 2023 00:01:38 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Thanks for taking the time to split the patch.  I’ve applied #1 and #2.

"J. Sims" <[email-masked]> skribis:

> From 569fabf7029200cbb3166af83b8fc89a6378468d Mon Sep 17 00:00:00 2001
> From: Juliana Sims <[email-masked]>
> Date: Tue, 28 Mar 2023 23:56:07 -0400
> Subject: [PATCH 3/3] gnu: gerbil: Enable all features.
>
> * gnu/packages/scheme.scm (gerbil): Enable all features.

[...]

> +                           "--enable-leveldb"
> +                           "--enable-libxml"
> +                           "--enable-libyaml"
> +                           "--enable-lmdb"
> +                           "--enable-mysql"
> +                           "--enable-sqlite"
> +                           "--enable-zlib")))
>                 (add-before 'patch-generated-file-shebangs 'fix-gxi-shebangs
>                   (lambda _
>                     ;; Some .ss files refer to gxi using /usr/bin/env gxi
> @@ -1202,8 +1211,18 @@ (define-public gerbil
>                       (copy-recursively "../bin" bin)
>                       (copy-recursively "../lib" lib)))))
>             #:tests? #f))
> -    (native-inputs (list coreutils gambit-c util-linux))
> -    (propagated-inputs (list gambit-c openssl sqlite zlib))
> +    (native-inputs (list coreutils
> +                         gambit-c
> +                         util-linux))
> +    (propagated-inputs (list gambit-c
> +                             leveldb
> +                             libxml2
> +                             libyaml
> +                             lmdb
> +                             mysql
> +                             openssl
> +                             sqlite
> +                             zlib))

I have two questions:

  1. What’s the impact on ‘guix size gerbil’?  Overall we should find a
     balance between feature usefulness and size.

  2. Do all these really need to be propagated?  Shouldn’t they be
     regular inputs?  If propagation is required, please add a comment
     explaining why.

I propose to close this issue since the initial goal has been met, but
please open a new one to follow up on this.

Thanks!

Ludo’.