Subject: Re: [bug#57426] [PATCH] gnu: Add emacs-consult-org-roam.
From: Nicolas Goaziou <[email-masked]>
To: Nicolas Graves via Guix-patches via <[email-masked]>
Cc: Nicolas Graves <[email-masked]>, [email-masked]
Date: Sat, 27 Aug 2022 10:18:54 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Nicolas Graves via Guix-patches via <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-consult-org-roam): New variable.

Applied with the changes below. Thank you.

> +(define-public emacs-consult-org-roam
> +  (let* ((commit "9b51aed939054c54934a6969290ad78587051cde")

I used latest commit instead.

> +         (revision "0"))
> +    (package
> +      (name "emacs-consult-org-roam")
> +      (version (git-version "0" revision commit))

Base version is "0.1" according to "Version:" keyword.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/jgru/consult-org-roam.git")

I removed the ".git" suffix from URL.

> +      (propagated-inputs (list emacs-org-roam emacs-consult))

I sorted inputs alphabetically.

> +      (description
> +       "This is a set of functions to use org-roam with consult.  This
> +packages replaces org-roam's own completing read functions with equivalent
> +versions utilizing consult's internal API.  By doing so, one gains all
> +advantages of consult which enhances Emacs' own completing-read
> +funcionality.")

I removed last sentence, which didn't seem useful in a description.
Also, I used capitalization for project's names (e.g., Consult).

> +      (license license:gpl3))))

License is actually GPL3+.

Regards,
-- 
Nicolas Goaziou