Subject: Dropping versioned docdir for license files?
From: Maxim Cournoyer <[email-masked]>
To: bug-guix <[email-masked]>
Date: Thu, 03 Mar 2022 08:37:39 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Guix,

Recently while packaging sysbench, I noticed that the gnu-build-system's
docdir expands to 'share/doc/name', while the 'install-license-files'
phase installs the license files to 'share/doc/name-version' instead:

--8<---------------cut here---------------start------------->8---
$ find /gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/bin
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/bin/sysbench
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/etc
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/etc/ld.so.cache
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/doc
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/doc/sysbench
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/doc/sysbench/manual.html
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/doc/sysbench-1.0.20
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/doc/sysbench-1.0.20/COPYING
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/bulk_insert.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/oltp_delete.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/oltp_insert.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/oltp_read_only.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/oltp_point_select.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/oltp_update_index.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/oltp_read_write.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/oltp_update_non_index.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/select_random_points.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/select_random_ranges.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/oltp_write_only.lua
/gnu/store/97q84ivbx8xa2lm3pn4pyb3i96n58i5g-sysbench-1.0.20/share/sysbench/oltp_common.lua
--8<---------------cut here---------------end--------------->8---

It seems to me it'd be nicer to have both agree on the same docdir.  We
could drop the version and use gnu-build-system's docdir, or alter the
default gnu-build-system docdir to use a versioned output.  The later
some more troublesome, as we'd have to do the same adjustment for each
build system, and I'm not convinced of the value added.  So I'd suggest
we simply normalize to use the standard docdir.

What do you think?

Thanks,

Maxim