Subject: Re: [bug#53315] [PATCH 150/150] gnu: Add alfis.
From: Nicolas Goaziou <[email-masked]>
To: Aleksandr Vityazev <[email-masked]>
Cc: [email-masked]
Date: Sat, 22 Jan 2022 13:57:13 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Aleksandr Vityazev <[email-masked]> writes:

> * gnu/packages/crates-io.scm (alfis): New variable.

Applied the whole set, barring a few unnecessary or already applied patch.

> +(define-public alfis
> +  (package
> +    (name "alfis")
> +    (version "0.6.10")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/Revertron/Alfis")
> +             (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32 "1kgzz92mkyzn7mbsdpik1q21kl38i4almn01k99nww3p0vgx9514"))))
> +    (build-system cargo-build-system)
> +    (arguments
> +     `(#:tests? #f                      ;tests failed

The comment is a bit terse. If they fail, it is better to explain the
kind of failure, if possible. In any case, I just skipped the two
failing tests.

> +       #:rust ,rust-1.57

This is not needed anymore since rust defaults to 1.57.

> +       #:cargo-development-inputs
> +       (("rust-serde-bytes" ,rust-serde-bytes-0.11)
> +        ("rust-serde-derive" ,rust-serde-derive-1.0.126))))

The package builds with rust-serde-derive-1, so I just used that and
dropped the patch adding rust-serd-derive-1.0.126. I had to relax
requirements for rust-zeroize-1, tho.

Thank you!

Regards,
-- 
Nicolas Goaziou