Subject: Re: [bug#49715] [PATCH] gnu: Add gmic-qt-gimp.
From: Leo Famulari <[email-masked]>
To: Vinicius Monego <[email-masked]>
Cc: [email-masked], Ivan Gankevich <[email-masked]>
Date: Fri, 22 Oct 2021 16:32:13 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

On Fri, Oct 22, 2021 at 02:14:15PM +0000, Vinicius Monego wrote:
> Hi,
> 
> > * gnu/packages/image-processing.scm (gmic-qt-gimp): New variable.
> 
> I built and tested this patch and can confirm it works. A few nitpicks
> that I have:
> 
> > +    (inputs
> > +      ;; GIMP and its dependencies.
> > +      `(("gimp" ,gimp)
> > +        ("gdk-pixbuf" ,gdk-pixbuf)
> > +        ("cairo" ,cairo)
> > +        ("gegl" ,gegl)
> > +        ,@(package-inputs gmic-qt)))
> 
> Should be one space below inputs. Also the labeled inputs should be
> sorted alphabetically. See the gmic-qt package for instance.
> 
> > +    (arguments
> > +      (substitute-keyword-arguments (package-arguments gmic-qt)
> > +        ((#:configure-flags flags)
> > +         '(list "-DGMIC_QT_HOST=gimp" "-DENABLE_DYNAMIC_LINKING=ON"
> > +                (string-append "-DGMIC_LIB_PATH="
> > +                               (assoc-ref %build-inputs "gmic")
> > "/lib")))))
> 
> Should be one space below arguments (see gmic-qt-krita for instance).
> 
> If you're using Emacs, the indentation should be fixed automatically
> with M-x indent-sexp or indent-region.

Thanks for the patch and the review, everybody!

I made the requested changes and pushed as
41492639e0223dc8fc1a357e1f9537577c055db7