Subject: Re: [PATCH] gnu: icecat: Add libxscrnsaver to runtime LD_LIBRARY_PATH
From: Jakub Kądziołka <[email-masked]>
To: Ivan Kozlov <[email-masked]>
Cc: [email-masked]
Date: Sun, 26 Jul 2020 13:14:30 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On Thu, Jul 09, 2020 at 01:00:05AM +0300, Ivan Kozlov wrote:
> IceCat loads libXss.so at runtime to inhibit screen locking if other interfaces are unavailable.
> 
> diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
> index fa430837f9..123e8bd889 100644
> --- a/gnu/packages/gnuzilla.scm
> +++ b/gnu/packages/gnuzilla.scm
> @@ -1115,10 +1115,12 @@ from forcing GEXP-PROMISE."
>                      (mesa (assoc-ref inputs "mesa"))
>                      (mesa-lib (string-append mesa "/lib"))
>                      (pulseaudio (assoc-ref inputs "pulseaudio"))
> -                    (pulseaudio-lib (string-append pulseaudio "/lib")))
> +                    (pulseaudio-lib (string-append pulseaudio "/lib"))
> +                    (libxscrnsaver (assoc-ref inputs "libxscrnsaver"))
> +                    (libxscrnsaver-lib (string-append libxscrnsaver "/lib")))
>                 (wrap-program (car (find-files lib "^icecat$"))
>                   `("XDG_DATA_DIRS" prefix (,gtk-share))
> -                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib)))
> +                 `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,mesa-lib ,libxscrnsaver-lib)))
>                 #t))))))
>      (home-page "https://www.gnu.org/software/gnuzilla/")
>      (synopsis "Entirely free browser derived from Mozilla Firefox")

Hi Ivan,

I gave your patch a test ride and playing videos in IceCat now correctly
inhibits the screensaver. Thanks!

I adjusted the commit message a bit and pushed the patch to master:

commit f11d429071e9350f671bc75cb899fb464c147092 (HEAD -> master, upstream/master)
Author: Ivan Kozlov <[email-masked]>
Date:   Thu Jul 9 01:00:05 2020 +0300

    gnu: icecat: Add libxscrnsaver to runtime LD_LIBRARY_PATH

    IceCat loads libXss.so at runtime to inhibit screen locking if other interfaces are unavailable.

    * gnu/packages/gnuzilla.scm (icecat)[arguments]: Add libxscrnsaver to
    wrap-program arguments.

    Signed-off-by: Jakub Kądziołka <[email-masked]>

Regards,
Jakub Kądziołka