Subject: Re: bug#42113: 28.0.50; Segmentation fault in json-parse-file
From: Philipp Stephani <[email-masked]>
To: Erik Hetzner <[email-masked]>
Cc: [email-masked]
Date: Mon, 29 Jun 2020 12:37:16 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Am Mo., 29. Juni 2020 um 10:33 Uhr schrieb Philipp Stephani
<[email-masked]>:
>
> Am So., 28. Juni 2020 um 23:53 Uhr schrieb Erik Hetzner <[email-masked]>:
> >
> > 1. Start emacs -Q
> > 2. Evaluate the following
> > (require 'dom)
> >
> > (with-current-buffer (url-retrieve-synchronously "https://www.seriouseats.com/recipes/2020/06/florentine-omelette-spinach-and-cheese.html")
> >         (let* ((dom (libxml-parse-html-region (point-min) (point-max)))
> >                (scripts (dom-by-tag dom 'script))
> >                (json-lds-raw (dom-elements scripts 'type "^application/ld\\+json$"))
> >                (json-lds (mapcar #'json-parse-string json-lds-raw)))))
> >
> > Result: segmentation fault.
>
> Simpler: (json-parse-string 1)
> The JSON functions are missing CHECK_STRING in several places where
> json_encode is called.

Fixed on the release branch (commit 59e768d64a).