Subject: Re: [bug#41553] [PATCH] gnu: Add spectacle-analyzer.
From: Marius Bakke <[email-masked]>
To: Alexandros Theodotou <[email-masked]>, [email-masked]
Date: Sat, 30 May 2020 13:45:14 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Alexandros Theodotou <[email-masked]> writes:

> Hi,
>
> This patch adds spectacle analyzer, an LV2 graphical spectrum analyzer
> (audio plugin).

Thanks!  Applied with the following changes:

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 08b9c19ec9..ac149a804c 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -141,6 +141,7 @@
   #:use-module (gnu packages tls)
   #:use-module (gnu packages version-control)
   #:use-module (gnu packages video)
+  #:use-module (gnu packages vim)       ;for 'xxd'
   #:use-module (gnu packages web)
   #:use-module (gnu packages wxwidgets)
   #:use-module (gnu packages xml)
@@ -4945,17 +4946,17 @@ and debugging of event signal flows inside plugin graphs.")
     (name "spectacle-analyzer")
     (version "1.0")
     (source
-      (origin
-        (method git-fetch)
-        (uri (git-reference
-               (url "https://github.com/jpcima/spectacle.git")
-               (commit (string-append "v" version))
-               ;; Bundles a specific commit of the DISTRHO plugin framework.
-               (recursive? #t)))
-        (file-name (git-file-name name version))
-        (sha256
-          (base32
-            "0xiqa6z8g68lcvnwhws4j7c4py35r9d20cirrili7ycyp3a6149a"))))
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/jpcima/spectacle.git")
+             (commit (string-append "v" version))
+             ;; Bundles a specific commit of the DISTRHO plugin framework.
+             (recursive? #t)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0xiqa6z8g68lcvnwhws4j7c4py35r9d20cirrili7ycyp3a6149a"))))
     (build-system gnu-build-system)
     (arguments
      `(#:tests? #f                      ; no check target
@@ -4969,17 +4970,19 @@ and debugging of event signal flows inside plugin graphs.")
      `(("pkg-config" ,pkg-config)
        ("xxd" ,xxd)))
     (inputs
-      `(("cairo", cairo)
-        ("fftw", fftw)
-        ("fftwf", fftwf)
-        ("jack", jack-1)
-        ("lv2", lv2)
-        ("mesa", mesa)))
+     `(("cairo", cairo)
+       ("fftw", fftw)
+       ("fftwf", fftwf)
+       ("jack", jack-1)
+       ("lv2", lv2)
+       ("mesa", mesa)))
     (synopsis "Realtime graphical spectrum analyzer")
     (description "Spectacle is a real-time spectral analyzer using the
 short-time Fourier transform, available as LV2 audio plugin and JACK client.")
     (home-page "https://github.com/jpcima/spectacle")
-    (license license:isc)))
+    ;; The project is licensed under the ISC license, and files in
+    ;; sources/plugin carry the Expat license.
+    (license (list license:isc license:expat))))
 
 (define-public x42-plugins
   (package