Subject: Re: [bug#35905] [PATCH] find-package-by-name: reverse package load precedence
From: Ludovic Courtès <[email-masked]>
To: Robert Vollmert <[email-masked]>
Cc: [email-masked]
Date: Sun, 26 May 2019 23:04:05 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Robert,

Robert Vollmert <[email-masked]> skribis:

> From e484a11fa652c6e9cb4484c6f700b91f134e7156 Mon Sep 17 00:00:00 2001
> From: Robert Vollmert <[email-masked]>
> Date: Sat, 25 May 2019 08:40:38 +0200
> Subject: [PATCH] guix: find-package-by-name: list modules in path order
>
> A particular effect of this is that if there are ambiguous
> packages in a directory specified with `-L module_dir` and the
> distribution, the version from `module_dir` will be loaded,
> which is usually what would be expected. (E.g. for `guix build`
> or `guix package -i`.)
>
> * guix/discovery.scm (all-modules): Return modules in path order.
> * tests/guix-package.sh: Test local definitions take precedence.

Good catch, applied!  (I adjusted the summary line so that it mentions
“discovery”.)

Likewise, in case more than one packages match a given spec, packages of
third-party channels would take precedence over those coming from the
‘guix’ channel, contrary to what was intended.

Thanks for fixing it!

Ludo’.