Subject: Re: [bug#33849] [PATCH] gnu: Add polybar
From: Ludovic Courtès <[email-masked]>
To: Meiyo Peng <[email-masked]>
Cc: [email-masked]
Date: Tue, 25 Dec 2018 17:45:12 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Meiyo Peng <[email-masked]> skribis:

> Ludovic Courtès <[email-masked]> writes:
>
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (string-append "https://github.com/jaagr/polybar/releases/"
>>> +                           "download/" version "/polybar.tar"))
>>> +       (sha256
>>> +        (base32 "1zpsvh1n77bx7s6mqqh3ba828k9xbp35c2mjmcl9nywfp6r5ldqi"))
>>> +       (file-name (string-append name "-" version ".tar"))))
>>
>> Please use ‘git-fetch’ rather than downloading a generated tarball (it’s
>> a generated tarball, right?).
>
> No. This is a user uploaded release tarball. You can notice their
> difference. User uploaded tarball has "/releases/download/" in its URL.
>
> #+BEGIN_EXAMPLE
>   User uploaded:  https://github.com/jaagr/polybar/releases/download/3.3.0/polybar.tar
>   Auto generated: https://github.com/jaagr/polybar/archive/3.3.0.tar.gz
> #+END_EXAMPLE

Oh right, so that’s OK.

> I tried to use the git-fetch method first, but it failed to build
> because git-fetch doesn't fetch git submodules. Do we support
> recursively fetching git submodules?

Yes, just add (recursive? #t).

>>From 3faa9dcf77ca83972db6234a9af6b22325ee0311 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <[email-masked]>
> Date: Sun, 23 Dec 2018 23:05:38 +0800
> Subject: [PATCH] gnu: Add polybar.
>
> * gnu/packages/wm.scm (polybar): New variable.

Applied, thanks!

Ludo’.