Subject: Re: [bug#33518] [PATCH] gnu: Add vimb.
From: [email-masked] (Ludovic Courtès)
To: Timo Eisenmann <[email-masked]>
Cc: [email-masked]
Date: Tue, 27 Nov 2018 12:11:55 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Timo Eisenmann <[email-masked]> skribis:

> * gnu/packages/web-browsers.scm (vimb): New variable.

Applied with the following changes to placate ‘guix lint’ and to avoid
GitHub auto-generated tarballs (their contents may vary over time.)

Let me know if anything is amiss.

Thanks!

Ludo’.

diff --git a/gnu/packages/web-browsers.scm b/gnu/packages/web-browsers.scm
index 052d29dd25..f63f269ae0 100644
--- a/gnu/packages/web-browsers.scm
+++ b/gnu/packages/web-browsers.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2017 Eric Bavier <[email-masked]>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <[email-masked]>
 ;;; Copyright © 2018 Rutger Helling <[email-masked]>
+;;; Copyright © 2018 Timo Eisenmann <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -48,6 +49,7 @@
   #:use-module (gnu packages webkit)
   #:use-module (gnu packages xorg)
   #:use-module (guix download)
+  #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system python))
@@ -327,12 +329,14 @@ GUI.  It is based on PyQt5 and QtWebKit.")
     (version "3.3.0")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append "https://github.com/fanglingsu/vimb/archive/"
-                           version ".tar.gz"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/fanglingsu/vimb/")
+             (commit version)))
        (sha256
         (base32
-         "0v3daxs10nndxvcpvx8377aylfdismzkys5n5cs8m89c3fdy6vsw"))))
+         "1qg18z2gnsli9qgrqfhqfrsi6g9mcgr90w8yab28nxrq4aha6brf"))
+       (file-name (git-file-name name version))))
     (build-system glib-or-gtk-build-system)
     (arguments
      '(#:tests? #f ; no tests
@@ -349,9 +353,9 @@ GUI.  It is based on PyQt5 and QtWebKit.")
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (home-page "https://fanglingsu.github.io/vimb/")
-    (synopsis "Fast and lightweight vim like web browser")
+    (synopsis "Fast and lightweight Vim-like web browser")
     (description "Vimb is a fast and lightweight vim like web browser based on
-the webkit web browser engine and the GTK toolkit. Vimb is modal like the great
-vim editor and also easily configurable during runtime. Vimb is mostly keyboard
+the webkit web browser engine and the GTK toolkit.  Vimb is modal like the great
+vim editor and also easily configurable during runtime.  Vimb is mostly keyboard
 driven and does not detract you from your daily work.")
     (license license:gpl3+)))