Subject: Re: [bug#31914] [PATCH] gnu: Add emacs-atom-one-dark-theme.
From: Marius Bakke <[email-masked]>
To: Peter Mikkelsen <[email-masked]>
Cc: [email-masked]
Date: Tue, 03 Jul 2018 15:30:59 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Peter Mikkelsen <[email-masked]> writes:

> Hi, sorry for the delay
>
> Marius Bakke writes:
>
>> Hello Peter,
>>
>> Peter Mikkelsen <[email-masked]> writes:
>>
>>> Date: Tue, 19 Jun 2018 21:19:44 +0200
>>> User-agent: mu4e 1.0; emacs 26.1
>>> From c324b516d02a4cdb6b0035f5d0fae4b12e050a1f Mon Sep 17 00:00:00 2001
>>> * gnu/packages/emacs.scm (emacs-atom-one-dark-theme): New variable
>>
>> [...]
>>   
>>> +(define-public emacs-atom-one-dark-theme
>>> +  (package
>>> +   (name "emacs-atom-one-dark-theme")
>>> +   (version "20180607.1638")
>>> +   (source (origin
>>> +             (method url-fetch)
>>> +             (uri (string-append
>>> +                   "https://melpa.org/packages/atom-one-dark-theme-"
>>> +                   version ".el"))
>>
>> Could you change this to use a git checkout or release tarball instead?
>> MELPA does not preserve old versions, so this version might not be
>> around for long.
>
> I didn't know that, but since the last release is quite old, I decided
> to use a git checkout.
>
>>> +             (sha256
>>> +              (base32
>>> +               "1qhdhm0xa88jc5z15h1s5qwnzin7fccp2ndvqr0acp89zxi60jbq"))))
>>> +   (build-system emacs-build-system)
>>> +   (home-page
>>> +    "https://github.com/jonathanchu/atom-one-dark-theme")
>>> +   (synopsis "Atom One Dark color theme for Emacs")
>>> +   (description "An Emacs port of the Atom One Dark theme from Atom.io.")
>>> +   (license license:gpl3)))
>>
>> This should be GPL3+, as noted in atom-one-dark-theme.el.  Can you send
>> an updated patch please?
>
> I have attached an updated patch :)

Thank you!  I've applied the patch, with one modification: the latest
git tag is "0.4.0"; and the same version number appears in the
commentary of atom-one-dark-theme.el, so it seemed more accurate than
"0.1".