Subject: Re: [bug#31382] [PATCH] telephony: add twinkle
From: Eric Bavier <[email-masked]>
To: "Jovany Leandro G.C" <[email-masked]>
Cc: [email-masked]
Date: Tue, 8 May 2018 22:14:35 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello Jovany,

On Mon, 7 May 2018 17:35:23 -0500
"Jovany Leandro G.C" <[email-masked]> wrote:

> From 1a2504b36e0775443587faf43e3a2d9467769866 Mon Sep 17 00:00:00 2001
> From: "Jovany Leandro G.C" <[email-masked]>
> Date: Mon, 7 May 2018 17:32:57 -0500
> Subject: [PATCH] telephony: add twinkle
> 
> ---
>  gnu/packages/telephony.scm | 66 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 66 insertions(+)

LGTM.  It even builds with --check/--rounds ! :)   Thanks.

I pushed this in commit b61cb24492c150b5eebb5227f2a7c32e4d42e1d4 with
the slight modifications below:

diff --git a/gnu/packages/telephony.scm b/gnu/packages/telephony.scm
index fe763c517..40e57051e 100644
--- a/gnu/packages/telephony.scm
+++ b/gnu/packages/telephony.scm
@@ -31,6 +31,7 @@
   #:use-module (gnu packages avahi)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages file)
   #:use-module (gnu packages protobuf)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages linux)
@@ -51,6 +52,7 @@
   #:use-module (guix packages)
   #:use-module (guix download)
   #:use-module (guix git-download)
+  #:use-module (guix build-system cmake)
   #:use-module (guix build-system gnu))
 
 (define-public commoncpp
@@ -542,9 +544,9 @@ Mumble consists of two applications for separate usage:
       ("qtdeclarative" ,qtdeclarative)
       ("qtquickcontrols" ,qtquickcontrols)))
    (home-page "http://twinkle.dolezel.info/")
-   (synopsis "Softphone for your voice over IP and instant messaging communcations")
+   (synopsis "Softphone for voice over IP and instant messaging")
    (description "Twinkle is a softphone for your voice over IP and instant
 messaging communcations using the SIP protocol.  You can use it for direct IP
 phone to IP phone communication or in a network using a SIP proxy to route your
 calls and messages")
-   (license license:gpl2))))
+   (license license:gpl2+))))