Subject: Re: [bug#29413] Add inputs for pcmanfm and a CVE-2017-8934 patch
From: [email-masked] (Ludovic Courtès)
To: [email-masked]
Cc: [email-masked]
Date: Thu, 23 Nov 2017 22:56:40 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Brendan,

[email-masked] skribis:

> From 8373ad3d6c23fbff27b4ddf9b5d81f3228ff8654 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <[email-masked]>
> Date: Fri, 24 Nov 2017 02:22:53 +1100
> Subject: [PATCH 1/2] gnu: pcmanfm: Add missing inputs. Remove comment.
>
> * gnu/packages/lxde.scm
> [inputs]: Add gvfs, for trash and mounting support.
> [propagated-inputs]: Add lxmenu-data, for "Open With..." Applications list.
> Remove comment suggesting to use --sysconfdir. Inspection of the configure
>   script shows that <output>/etc is used for configuration by default anyway,
>   so such a flag is not needed.

I moved the explanations as comments in the code (next to the inputs),
adjusted the commit log for style, and committed.

> From fe1e4cf4c88395cef87a0263acf587672b3132ac Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <[email-masked]>
> Date: Fri, 24 Nov 2017 02:57:00 +1100
> Subject: [PATCH 2/2] gnu: pcmanfm: Fix CVE-2017-8934.
>
> * gnu/packages/patches/pcmanfm-CVE-2017-8934.patch: New file. This patch was
>   imported from Archlinux.
> * gnu/local.mk (dis_patch_DATA): Add it.
> * gnu/packages/lxde.scm[source]: Use it.

Applied.

Thanks!

Ludo’.