Subject: Re: [bug#28552] [PATCH 2/3] gnu: Add infiniband-diags.
From: [email-masked] (Ludovic Courtès)
To: Dave Love <[email-masked]>
Cc: [email-masked]
Date: Sat, 23 Sep 2017 18:03:15 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Dave Love <[email-masked]> skribis:

> * gnu/packages/fabric-management.scm (infiniband-diags): New variable.

Applied with the cosmetic changes below.

Thanks,
Ludo'.

diff --git a/gnu/packages/fabric-management.scm b/gnu/packages/fabric-management.scm
index 4c6f21a98..edb058842 100644
--- a/gnu/packages/fabric-management.scm
+++ b/gnu/packages/fabric-management.scm
@@ -96,7 +96,7 @@ running the opensm daemon.")
        ("glib" ,glib)))
     (outputs '("out" "lib"))
     (native-inputs
-     ;; fixme: needs rst2man for man pages
+     ;; FIXME: needs rst2man for man pages
      `(("autoconf" ,autoconf)
        ("automake" ,automake)
        ("libtool" ,libtool)
@@ -126,16 +126,14 @@ running the opensm daemon.")
                    (perlin (string-append (assoc-ref %outputs "lib")
                                           "/lib/perl5")))
                (mkdir-p perlout)
-               (zero? (system* "mv" perlin perlout))))))))
+               (rename-file perlin perlout)
+               #t))))))
     (home-page "https://github.com/linux-rdma/infiniband-diags")
     (synopsis "Infiniband diagnotic tools")
-    (description "\
-A set of utilities designed to help configure, debug, and maintain infiniband
-fabrics.  Many tools and utilities are provided, some with similar
-functionality.
+    (description "This is a set of command-line utilities to help configure,
+debug, and maintain Infiniband (IB) fabrics.
 
-In addition to the utilities provided, a sub-library libibnetdisc, is provided
+In addition to the utilities, a sub-library, @file{libibnetdisc}, is provided
 to scan an entire IB fabric and return data structures representing it.  The
 interface to this library is not guaranteed to be stable.")
-    (license
-     (list gpl2 bsd-2)))) ; dual
+    (license (list gpl2 bsd-2)))) ; dual