Subject: Re: [bug#28378] [PATCH] gnu: Add heimdall.
From: Julien Lepiller <[email-masked]>
To: [email-masked]
Date: Tue, 3 Oct 2017 21:46:27 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Le Wed, 20 Sep 2017 22:34:23 +0200,
[email-masked] (Ludovic Courtès) a écrit :

> Hi Julien,
> 
> Julien Lepiller <[email-masked]> skribis:
> 
> > From 0cd2378f5aa2626f8118d607a6b3558c212d80ec Mon Sep 17 00:00:00
> > 2001 From: Julien Lepiller <[email-masked]>
> > Date: Tue, 29 Aug 2017 23:54:16 +0200
> > Subject: [PATCH] gnu: Add heimdall.
> >
> > * gnu/packages/flashing-tools.scm (heimdall): New variable.
> >
> > Co-Authored-By: Danny Milosavljevic <[email-masked]>  
> 
> It LGTM.  I don’t see why libpit.a is needed, but I’ll let you
> decide.  :-)
> 
> > +    (build-system cmake-build-system)
> > +    (arguments
> > +     `(#:configure-flags '("-DCMAKE_BUILD_TYPE=Release")  
> 
> Why not keep the default “RelWithDebInfo”?
That's what was documented in this package.

Pushed as f282aa530b91c8fecb910bc0a3323fcbd4d39ffb.

> 
> Thanks!
> 
> Ludo’.