Hello Dmitry, thanks for the feedback.<br><br>On Tue, Nov 3, 2015 at 3:00 AM, Dmitry Gutov &lt;dgutov@yandex.ru&gt; wrote:<br><blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;">I have to say, I'm still not very comfortable with mixing it sort of alien logic inside json-read-object and json-read-array (would anyone else like to chime in with their opinion?).</div></blockquote><div><br></div>I understand your uneasiness, I feel the same way after you pointed it<div>out.<br><br><blockquote type="cite"><div class="plaintext" style="white-space: pre-wrap;">Here's an idea: both json-read-object-1 and json-read-array-2 will advise json-read to add the new logic around calls to it (there will have to be some guard in the advice, so that recursive calls are run unmodified).</div></blockquote><br></div><div>I'm reluctant to use advises for it, not based on my own experience, but</div><div>based on advice from the Elisp manual:</div><div><br></div><blockquote type="cite"><div>[...] advice should be reserved for the cases where you cannot modify</div><div>a function’s behavior in any other way. [...] In particular, Emacs’s</div><div>own source files should not put advice on functions in Emacs. (There</div><div>are currently a few exceptions to this convention, but we aim to</div><div>correct them.)</div></blockquote><div><br></div><div>Here we do have a chance to modify the functions' behavior.</div><div><br></div><div>How about a sort of compromise between our approaches: provide</div><div>'json-read-object' and 'json-read-array' with pre- and post-read</div><div>callback functions, that are only called when they're set. That would</div><div>make it possible to leverage the power of 'json-read-object' and</div><div>'json-read-array' by binding the callback functions, without mixing</div><div>alien logic into them.</div><div><br></div><div>That would also make it a lot cleaner when adding other extensions to</div><div>them in the future, compared to my original suggestion.</div><div><br></div><div>If that sounds good to you, I'll cook up a new patch!</div><div><br></div><div>-- Simen</div>