On 06/13/2014 10:29 AM, Pádraig Brady wrote:The latter doesn't sound safe, since it would mean the files in libcoreutils.a would be compiled without -D_THREAD_SAFE and would thus access a global shared errno even when linked with sort.c. So I vote for the former.
So I'd be inclined to add those definitions in the pthread module,
but if not we could define at the top of sort.c at least?