Subject: Re: bug#15650: "cp: warning: source file ‘f’ specified more than once" said more than once too!
From: Pádraig Brady <[email-masked]>
To: [email-masked]
Cc: [email-masked]
Date: Wed, 30 Oct 2013 10:53:58 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

tag 15659 wontfix
stop

On 10/19/2013 11:28 AM, [email-masked] wrote:
> $ touch f
> $ mkdir w
> $ cp f f f w
> cp: warning: source file ‘f’ specified more than once
> cp: warning: source file ‘f’ specified more than once
> 
> Hey, you yourself say that more than once itself!
> 
> So either say
> cp: warning: source file ‘f’ specified more than once
> just once, or say
> cp: warning: source file ‘f’ specified again
> n-1 times.

So we record this about each arg:

struct F_triple
{
  char *name;
  ino_t st_ino;
  dev_t st_dev;
};

I suppose we could add a 'count' member,
and a corresponding seen_file_count() function.

Though I don't think the complication/clarification
is warranted in this case.

thanks,
Pádraig.