tags 9890 patch thanks On Thursday 27 October 2011, Zack Weinberg wrote: > If you use AM_MAINTAINER_MODE([enable]), configure will print > > > checking whether to disable maintainer-specific portions of Makefiles ... yes > > when --disable-maintainer-mode was *not* given on the command line, and > > > checking whether to disable maintainer-specific portions of Makefiles ... no > > when it *was* given. This states the opposite of what has actually happened. > > The easiest way to fix this cosmetic bug is to not use > am_maintainer_other in the first argument to AC_MSG_CHECKING. The > result code ($USE_MAINTAINER_MODE) is "yes" if maintainer mode is > enabled and "no" if it isn't, regardless of what the default was, so > it will always be correct to say "checking whether to enable ...". > Patch attached. > > (Bug found in automake/aclocal 1.11, but maintainer.m4 doesn't seem to > have been modified in a long time.) > Thanks for the analysis and solution. I've applied your diff, and added a testcase. Attached is the patch I intend to push shortly (I'll give a couple of days for reviews and objections). Also, I have a minor question: Zack, are you the same "Zack Weinberg" already listed in the THANKS file with the address "zack@codesourcery.com"? If yes, should I update that address? Regards, Stefano