On 01/07/2012 07:21 AM, Ryan Lortie wrote:
> hi,
>
Hi Ryan, and thanks for the patches.

> Here are a pair of patches that should fix this issue.
>
I must admit I dont' like very much the idea of having the stamp file created
in the $(srcdir) ...  but I see that the .c files generated by Vala are already
being placed in the $(srcdir) -- so you are just following the existing trend,
and you changes are a definite improvement over the existing broken situation.
So I think they are definitely good to apply.

I've edited your patches a bit to fix a couple of minor blunders and to
improve conformance to the GNU Coding Standards; since I was at it, I've
thrown in (into the second patch) an additional fix for another pre-existing
VPATH-related bug.  I've also added a tiny new patch to fix an independent
testsuite weakness (missing requirement of GNU make in vala-vpath.test).

Attached is what I'll pushed to maint in 72 hours, if there is no objection.

Thanks again for tackling this issue!

Best regards,
  Stefano