On Sun, Sep 21 2025, Eli Zaretskii wrote: >> From: Timo Myyrä >> Date: Sun, 21 Sep 2025 11:27:44 +0300 >> >> Here is an patch to implement `w' binding in the log-view-mode-map to >> copy the revision string to kill-ring. Helps when the revision is >> required in some other command. >> This tries to follow the same idiom as in the dired mode where `w' >> copies the filename under point to kill ring. > > Thanks. > >> --- a/etc/NEWS >> +++ b/etc/NEWS >> @@ -2330,6 +2330,12 @@ You can get back the old behavior with something like this: >> (with-eval-after-load 'log-view >> (keymap-set log-view-mode-map "m" #'log-view-toggle-mark-entry)) >> >> +--- >> +*** A new function `log-view-copy-revision-as-kill' added > > Heading lines in NEWS must end in a period. Also, please quote 'like > this' in NEWS. > >> +The log-view now provides new `log-view-copy-revision-as-kill' function > ^^^^^^^^ > "command". > > Also, there's no need to tell which package provided the new command. > So something like > > The new command 'log-view-copy-revision-as-kill' allows copying ... > > is better. > > And IMO the "-as-kill" part of the command's name is redundant. > >> +to copy the revision string under point to the kill-ring. The command is >> +bound by default to `w' in log-view-mode-map. > > Please use "at point", not "under point". (Actually, I believe a more > accurate wording is "revision string of the log entry at point".) Thanks for the quick feedback. I updated the patch accordingly. I kept the 'as-kill' part as there are multiple commands in emacs with same suffix. The new command mimics the functionality from dired where the command is named 'dired-copy-filename-as-kill' so I thought to keep the similar naming here. timo