Daniel Mendler writes: > Eli Zaretskii writes: > >>> From: Spencer Baugh >>> Cc: 79380@debbugs.gnu.org, Eli Zaretskii >>> Date: Fri, 05 Sep 2025 14:26:49 -0400 >>> >>> > Right, even better. Like this: >>> >>> Ping, I'd like to install this patch to fix the breakage on master. >> >> I was waiting for Daniel to test the patch and say that there are no >> further issues with it. >> >> Daniel, please chime in and ack. > > Works for me, yes. > > But there is still a small inconsistency in the patch. If the defcustom > is set to an invalid type there will be an error. But if it is set to an > invalid executable we will get a warning. Is this desired? That was deliberate, yes. If a user sets elisp-flymake-byte-compile-executable to "src/emacs" in dir-locals in the Emacs repo, but they haven't compiled Emacs yet, I figure they would prefer that flymake fall back to using their running Emacs instance rather than error because repo/src/emacs doesn't exist. That being said, since this is unclear I think the message for that case could be improved. Also, some of the nested conditionals indeed can be removed. Hence, this patch, which I think seems good to me. (We don't need to check file-executable-p in the absolute file name case, where we don't need to fall back; start-process will just error, just like it would if (expand-file-name invocation-name invocation-directory) doesn't exist anymore) >> Thanks. However, the log message still says the defcustom is being >> modified, which the patch doesn't do. Fixed, thanks.