Hello,

On Thu 14 Aug 2025 at 06:10pm +03, Eli Zaretskii wrote:

>> From: Sean Whitton <spwhitton@spwhitton.name>
>> Cc: dmitry@gutov.dev,  79024@debbugs.gnu.org
>> Date: Thu, 14 Aug 2025 14:43:10 +0100
>>
>> > The vc-test-hg07-other-working-trees test still fails, but in a
>> > different place now:
>> >
>> >   Test vc-test-hg07-other-working-trees condition:
>> >       (error
>> >        "Failed (status 255): hg --config ui.report_untrusted=0 --config=extensions.share= commit -A -l c:/Users/EliZ/AppData/Local/Temp/hg-msgjR8Sup foo")
>> >
>> > Any ideas?
>>
>> Hmm, I recently changed vc-do-command to print command output for
>> failing commands.  I assume there's nothing showing up?
>
> Do you mean this:
>
>   Checking in foo...
>   abort: no username supplied
>   (use 'hg config --edit' to set your username)

Looks like the problem is determining the committer identity.

I think the attached patch will fix this.  I've tested it locally and it
does result in the test commits having the john@doe.ee identity.
Could you test it on Windows?  Thanks.

>> I would suggest trying this manually something like this (translated to
>> Windows speak)
>>
>>     mkdir foo
>>     cd foo
>>     hg init
>>     echo foo >bar
>>     hg add bar
>>     echo msg >../tmp
>>     hg --config ui.report_untrusted=0 --config=extensions.share= commit
>>     -A -l ../tmp bar
>
> This works here, and the last command exits with zero status.  Does
> the above really faithfully reproduces what the test does?

It reproduces it in terms of commands but I guess that hg's identity
autodetection works differently from the test's temporary directory than
it does from the more ordinary directory where you tried these commands.

-- 
Sean Whitton