Alan Third writes: > On Fri, May 23, 2025 at 03:42:53PM +0200, Manuel Giraud wrote: >> Alan Third writes: >> >> > On 23 May 2025 12:19:15 BST, Manuel Giraud wrote: >> >>Alan Third writes: >> >> >> >>> On Fri, May 23, 2025 at 12:18:26PM +0200, Manuel Giraud wrote: >> >>>> Hi Alan, >> >>>> >> >>>> Here is what I get: >> >>> >> >>> Thank you. That's what I see too. Are you able to send me an example >> >>> SVG as generated by docview? >> >> >> >>Sure. Here is some book with light theme and a dark theme (pretty >> >>unreadable ;-) >> > >> > Sorry, is it possible to get a copy of the actual SVG file, please? >> >> Here is an example from my docview cache. > > Clearly an excellent document. 😅 > OK, I'm pretty sure that the first patch that affects image.c is > working right, which means my mediocre lisp skills are biting me here. > > Can you try running > > (concat "svg{fill:" (face-foreground 'doc-view-svg-face) "}") > > and see what it returns? Just to be sure we're on the same page: I'm doing all those test on top the patches you provided in this thread. For both a light theme or a dark theme, I get "svg{fill:}". > Although it's only just now occurred to me that I have no idea what > face-foreground might return, presumably things that aren't CSS > compatible? > > Hmm... > > Can you try replacing line 1680 in lisp/doc-view.el with > > :foreground (face-foreground 'doc-view-svg-face) > :css "svg{fill:currentcolor;}"))) > > I think that's the right number of brackets... I was not sure so here is the patch I used: