On 2025-03-22, Vagrant Cascadian wrote:
> On 2025-03-22, pelzflorian (Florian Pelz) wrote:
>> Vagrant Cascadian <vagrant@debian.org> writes:
>>> +    (version "278f964619e597bf0b3aae67fef52bb541bc89e6")
>>
>> This is a bad version; newer versions are not increasing.
>
> Yeah, I wondered about this... did not think it mattered too much
> because it just ships some patch files used as an input; it is not a
> package someone is likely to include in a profile where the version
> would matter. Might be a case for using (define ... instead of
> (define-public ... of course I can make up a more meaningful
> git-commit-hash derived version if we absolutely must... :)

Used a version based on the output from git describe.


>> The commit 278f964619e597bf0b3aae67fef52bb541bc89e6 you use for
>> reform-debian-packages is no longer the most recent commit.  Which commit
>> should we use?
>
> Current head is probably also fine (seems to have one new or updated
> patch to the relevent kernel patches which might require adjusting patch
> phase), but that was the commit I tested so far.

Updated to the latest commit, which updated one of the patches (but did
not change names, so no further updates needed in the packaging.


>> Vagrant Cascadian <vagrant@debian.org> writes:
>>> +    (license (list
>>> +              ;; FIXME license:mit
>>> +              ;; FIXME license:FSFAP
>>> +              license:bsd-2
>>> +              license:gpl2
>>> +              license:gpl2+
>>> +              license:gpl3))))
>>
>> Likely should be
>> (list license:gpl2
>>       license:gpl2+
>>       license:gpl3+
>>       license:x11
>>       license:expat
>>       license:fsf-free)
>
> Sounds plausible to me. :)

I incorporated all these; they seem consistent with my observations,
although fsf-free required arguments.


>> https://source.mnt.re/reform/reform-debian-packages/-/blob/main/reprepro.sh?ref_type=heads
>> has no license :(
>> Remove it in an origin snippet?
>> Though you also do not use this tiny script.
>
> I can probably get upstream to fix that, but we also do not need it at
> all.

Working on submitting the issue upstream...

Changes since v2:

reform-debian-packages:
* Update to 2023-07-10-318-g85274b8.
* Update license field.

linux-libre-arm64-mnt-reform:
* Add ATH9K wireless to configuration.

live well,
  vagrant