Hi Ludovic,

Thank you for the review.

On 3/1/25 08:35, Ludovic Courtès wrote:
>> +          (uri (svn-reference
>> +                (url "https://svn.code.sf.net/p/supertuxkart/code/stk-assets")
>> +                (revision (string->number commit))))
> How come the assets are at sf.net, in an svn repo, when the rest is in
> Git at github.com?

Their https://supertuxkart.net/Source_control page states simply:

   "SupertTuxKart uses Git for source code, and SVN for data files."

I don't know of any rationale beyond that.

>> +              #~(modify-phases %standard-phases
>> +                  (add-after 'unpack 'copy-code-data
>> +                    (lambda _
>> +                      (copy-recursively
>> +                       (string-append #$supertuxkart-source "/data/")
>> +                       "."))))))
> I’d suggest adding ‘supertuxkart-source’ to the ‘inputs’ field and, in
> the phase above, do:
>
>    (copy-recursively
>      #$(this-package-input (git-file-name "supertuxkart" %supertuxkart-version))
>      ".")

Thank you for the suggestion.  This is indeed better.

Revised patch attached.

`~Eric