Hi, thanks for reviewing.

On 20.09.2024 00:24, Liliana Marie Prikler wrote:
> Am Freitag, dem 20.09.2024 um 02:05 +0000 schrieb Eric Bavier:
>> +   (arguments
>> +    (list
>> +     #:tests? #f                        ; Tests require Qt5
> Is there a reason to build it with Qt 6 then? 🤔
> Alternatively, we might want to check if the tests can be built with Qt
> 6.  This requires a little more work.

I looked into this a little more.  It appears that the tests themselves 
are not maintained.  E.g. the most recent changes are several years 
behind other changes to the codebase, and there is at least one 
egregious typo ("#inlude") that prevents them from compiling even with 
Qt5.  So maybe we disable with "Tests unmaintained" as the reason 
instead.

>> +   (description
>> +    "AntiMicroX is a graphical program used to map gamepad keys to
>> keyboard, mouse,
>> +scripts, and macros.  Useful for controlling your system with a
>> gamepad or
>> +playing games that don't natively support gamepads.  It can also be
>> used for
>> +generating SDL2 configuration (useful for mapping atypical gamepads
>> to generic
>> +ones).  It support X.org and Wayland.")
>> +   (license license:gpl3+)))
> The description could use some polishing.  It should consist of
> complete sentences and there are some minor grammar mistakes as well.

Thanks, I've revised the description a bit in the attached updated 
patch.

> Also, I don't see a home-page (how does guix not complain about this?)

I placed home-page above source to avoid having to duplicate the github 
address.  There are about 452 other packages that do this.

-- 
`~Eric