Eli Zaretskii writes: >> From: Spencer Baugh >> Cc: jporterbugs@gmail.com, 72426@debbugs.gnu.org >> Date: Tue, 06 Aug 2024 14:49:45 -0400 >> >> Eli Zaretskii writes: >> >> >> From: Spencer Baugh >> >> Cc: jporterbugs@gmail.com, 72426@debbugs.gnu.org >> >> Date: Tue, 06 Aug 2024 12:42:09 -0400 >> >> >> >> --- a/lisp/startup.el >> >> +++ b/lisp/startup.el >> >> @@ -854,6 +854,10 @@ normal-top-level >> >> ;; We are careful to do it late (after term-setup-hook), although the >> >> ;; new multi-tty code does not use $TERM any more there anyway. >> >> (setenv "TERM" "dumb") >> >> + ;; Likewise, subprocesses should not use a pager unless told >> >> + ;; otherwise, since it generally won't work. >> >> + (when (executable-find "cat") >> >> + (setenv "PAGER" "cat")) >> > >> > We need to work on the comment, because it doesn't explain any of what >> > it needs to. Worse, it says something very confusing and at least >> > inaccurate. >> >> Could you just say what you'd prefer the comment to be? I'm not sure >> what exactly you'd like it to explain. > > I don't have a clear enough idea; I hoped you did, since you initiated > this change to begin with. I just know that the text you wrote cannot > be it, because it didn't explain to me anything about the reasons we > should be doing this. The comment should explain why PAGER=cat is a > good idea to go with TERM=dumb, for example. Maybe begin by saying > why Emacs needs to set the variable at all, why not leave it unset? OK, how about this?