[புதன் ஆகஸ்ட் 14, 2024] Eli Zaretskii wrote: >> From: Visuwesh >> Cc: monnier@iro.umontreal.ca, 72405@debbugs.gnu.org, drew.adams@oracle.com >> Date: Wed, 14 Aug 2024 12:57:17 +0530 >> >> >> Is the attached patch fine? >> > >> > Yes, but please use 'if' rather than 'when'. >> >> Sorry, but I'm confused. I used 'when' because >> >> (concat nil "xxx") ;; => "xxx" > > Yes, of course. But 'if' also returns nil if its condition is false: > > (if (symbolp 1) "symbol") > => nil > > So you can still use the original code, which uses the above behavior > of 'concat', after replacing 'when' with 'if' in your original code. > > The reason I asked to use 'if' is that there's no reason to use 'when' > here, as the BODY of 'when' will only ever be a single string. Ah, I understand now. I find using 'if' without the else-clause confusing when glancing at the code so I opted to use 'when'. Thanks for taking your time to explain what you meant. Attached patch replaces 'when' with 'if'.