On 2024-08-19 at 14:17+08:00, Zheng Junjie wrote:
> Nguyễn Gia Phong writes:
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url "https://github.com/zyantific/zycore-c")
> > +                    (commit (string-append "v" version))))
> > +              (sha256
> > +               (base32 "0s962pkqybh1xbs75y4jb4bqc9qnq0sviqd570mirqdhhq87agib"))
> > +              (file-name (git-file-name name version))))
>
> i move file-name before sha256.
>
> Nguyễn Gia Phong writes:
> > +    (build-system cmake-build-system)
> > +    (native-inputs (list googletest))
> > +    (arguments `(#:configure-flags '("-DZYCORE_BUILD_SHARED_LIBS=ON"
>                                         is ZYCORE_BUILD_SHARED_LIB
> > +                                     "-DZYCORE_BUILD_TESTS=ON")))
>
> i adjust to use gexp, and disable ZYCORE_BUILD_TESTS on cross-compilation.

On 2024-08-19 at 14:19+08:00, Zheng Junjie wrote:
> Nguyễn Gia Phong writes:
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url "https://github.com/zyantific/zydis")
> > +                    (commit (string-append "v" version))))
> > +              (sha256
> > +               (base32 "15iw6wcg2van8pw54xs15zk5cniqm8d8vbd1w1br9azv8jxsqjva"))
> > +              (file-name (git-file-name name version))))
>
> move file-name before sha256.
>
> Nguyễn Gia Phong writes:
> > +    (build-system cmake-build-system)
> > +    (arguments `(#:configure-flags '("-DZYAN_SYSTEM_ZYCORE=ON"
> > +                                     "-DZYDIS_BUILD_SHARED_LIB=ON"
> > +                                     "-DZYDIS_BUILD_MAN=ON")))
>
> use gexp.

Thanks for the nits and application to master!